Early game: tanks by a long shot
Mid game: tanks aren't quite as effective but are still best for capturing cities fast.
Late game: chances are, the only people playing are infantry spamming noobs who have maxed out infantry. (honestly I think permanent anti tank destroys the propose of infantry, maybe only give them the bonus when entrenched).
Tanks also suck at invading Iran and Chile, so use infantry for those.